improve robustness to broken input files #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can craft a Bloom filter file in which the number of hash functions (k) is an unsigned integer larger than the maximum signed integer on the given platform. This will cause a crash later when trying to
make()
a slice with that overly large size, as the length of a slice in Go is limited by the maximum value of (signed) int:It should be unlikely to create such a filter using the regular initializer, but such a filter can be read from a corrupted file.
This PR makes sure we fail early at load time when we notice that this value exceeds the given limit.