CMake with module based configuration #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SumolX
changed the title
SumolX
commented
Apr 7, 2024
engine/openbor.h
Outdated
| @@ -1790,8 +1790,6 @@ if(n<1) n = 1; | |||
| //#define MAX_MOVES 16 | |||
| //#define MAX_MOVE_STEPS 16 | |||
|
|
|||
| #pragma pack(4) | |||
There was a problem hiding this comment.
Have to be-careful with packing. If data structures are not written/read from disk or being transferred over communication protocols this flag can cause bad behaviors. I encountered an issue where the pointer being assigned with an array of 11 elements was fragment and yet the code is expecting contiguous memory storage.... mostly arm based devices would have trouble with this since x86 cpus will try to fetch the data twice from memory when not aligned.... not the case with arm.
… all cpu targets.
DCurrent
approved these changes
Apr 11, 2024
DCurrent
approved these changes
Apr 17, 2024
…etween 64 and 32 bit platforms.
DCurrent
approved these changes
Apr 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an alternative and cleaner approaching to managing build configuration for targets where each target will have a dedicated cmake modules (xxxx.cmake). The main CMakeLists.txt when updated with global based parameters automatically import the target properties... so it should be much more maintainable moving forward.