Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS animation never ends - Safari #320

Closed
JRegimbal opened this issue Apr 25, 2019 · 0 comments
Closed

CSS animation never ends - Safari #320

JRegimbal opened this issue Apr 25, 2019 · 0 comments
Assignees
@JRegimbal
Labels
bug Something isn't working core-functionality

Comments

@JRegimbal
Copy link
Collaborator

In Safari the loading animation never ends. Since it can't be dismissed this prevents the user from ever accessing the the viewer/editor.
@JRegimbal JRegimbal added bug Something isn't working core-functionality labels Apr 25, 2019
@JRegimbal JRegimbal self-assigned this Apr 25, 2019
JRegimbal added a commit that referenced this issue Apr 25, 2019
@JRegimbal
Disable loading animation at part of execution.
718c81f 
If we support Safari we can't rely on the load event to be triggered for
SVG elements. Even though this does seem to be the behavior defined by
W3, it just doesn't work in Safari (and presumably other webkit
browsers).

Code for the animation is kept in case we can find a more permanent
solution, but since we want to move to diva.js and won't be directly
loading images this isn't a high priority.

Resolve #320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JRegimbal JRegimbal

Labels
bug Something isn't working core-functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JRegimbal