New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix files according to ESlint rules #806

Merged

jinh0 merged 1 commit into develop from linting-fix

May 11, 2022

Collaborator

jinh0 commented May 11, 2022 •

edited

Loading

Fix files according to ESlint rules.

Changes to ESlint:

Remove no-use-before-define rule.
Add object-curly-spacing and quote-props so that our code looks prettier. 😃

Comments:

A lot of typing needs to be fixed.
ESlint still does not stop from long lines of code that go pass the standard 80 characters per line. Also, ESlint does not auto format such long lines. I'd suggest we use Prettier as an extension to ESlint. I've used Prettier extensively and it autoformats not just long lines of code but also long function signatures and long imports.


          Fix files according to ESlint rules.

14b1f1c

jinh0 requested a review from yinanazhou

May 11, 2022 16:42

jinh0 merged commit 3265341 into develop

jinh0 deleted the linting-fix branch

May 20, 2022 15:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet