Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented grouping/ungrouping hotkeys #811

Merged
merged 5 commits into from
May 17, 2022
Merged

Implemented grouping/ungrouping hotkeys #811

merged 5 commits into from
May 17, 2022

Conversation

cadagong
Copy link
Contributor

Adds one of requested features from request #665

@cadagong
Implemented grouping/ungrouping hotkeys
60e399b 
Finished implementing hotkeys for grouping/merging and ungrouping/splitting for syllables, neumes, neume components, and staves.
@cadagong cadagong changed the base branch from master to develop May 11, 2022 20:36
@yinanazhou
Copy link
Member

I got some error messages about no facsimile interface found. Could you please check that? Thanks!

@yinanazhou
Copy link
Member

Hi, I found that if I select the circled ncs in the select by neume components mode, no group options will appear. But if I press g, a verovio error will appear in the console.
image
image
Could you please disable the hotkey in situations like this? Thanks!

cadagong and others added 4 commits May 13, 2022 15:37
@cadagong
Implemented grouping/ungrouping hotkeys
10697a0 
Implemented grouping/merging and ungrouping/splitting hotkeys for Syllables, Neumes, Neume Components, and Staves.
@cadagong
Merge branch 'grouping-fix' of https://github.com/DDMAL/Neon into gro…
445c27e 
…uping-fix
@cadagong
Revert "Merge branch 'grouping-fix' of https://github.com/DDMAL/Neon …
6e6692a 
…into grouping-fix"

This reverts commit 445c27e, reversing
changes made to 10697a0.
@yinanazhou
minor changes
5a01a25
@yinanazhou yinanazhou merged commit fd2a1bd into develop May 17, 2022
@cadagong cadagong deleted the grouping-fix branch May 17, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinanazhou yinanazhou yinanazhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cadagong @yinanazhou