🏷 Add correct TypeScript types throughout the project #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinanazhou
requested changes
May 20, 2022
There was a problem hiding this comment.
- please fix the building errors.
- please remove the changes to EditorAction. EditorAction is good and clear in Neon. Specifying all the change request actions to Verovio may confuse people.
- please double-check the code and fully test it before making any pull requests.
+ Most significantly, editor actions. 🏷 Fix typing errors with new EditorAction.
yinanazhou
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #807 .
Most significantly, editor actions have been given a full makeover with exact types.