Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zoom shortcuts and up/down arrow reactivity🐛 #851

Merged
merged 2 commits into from
May 29, 2022

Conversation

chetbae
Copy link
Contributor

@chetbae chetbae commented May 28, 2022

deactivates default action on up and down arrow for slider, change shortcuts to _ and +.
Fixes #850

@chetbae chetbae requested a review from yinanazhou May 28, 2022 22:38
@chetbae
Copy link
Contributor Author

chetbae commented May 28, 2022

Need to reflect in hotkeys window. (but maybe would be better to do after modal windows are integrated? @yinanazhou?)

Copy link
Member

@yinanazhou yinanazhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already deactivated arrow right and arrow left, also updated hotkey info.

@yinanazhou yinanazhou merged commit 672c8b7 into develop May 29, 2022
@jinh0 jinh0 deleted the zoom-shortcut-fix branch August 22, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants