🐛♻️ Fix selection of multiple staves by cmd-click #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `this` keyword is annotated for type safety - Arrays are given SVGGraphicsElement[] to fix type errors - isMultiSelect() is used as a helper function for readability - Confusing variable names `mode` and `temp` are changed to `selectedClass` and `selectionMode` along with removing the switch case for the simpler "dictionary" lookup with `modeToClass`.
Previously, `unselect()` was called to unselect all previously selected elements, which should not happen when the user wants to select multiple staves. This issue is fixed by adding a check to see whether multiple selection is chosen or not.
yinanazhou
reviewed
Jun 23, 2022
yinanazhou
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #871 .
Refactors clickHandler() in Select.ts .