Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add sample folios selection to index page #918

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

chetbae
Copy link
Contributor

@chetbae chetbae commented Jul 12, 2022

Introduce sample folios back into new index page!

Amongst other things:

  • Remove distinction for folios and manuscripts in document selector after lab meeting discussion to stop working on diva.js mode
  • Remove filename extensions for selection
  • Fix unwanted behaviour after failed upload affecting all other upload promises (more in commit msgs)

additionally fix document selector not reflecting changes after uploading pairs or manuscripts, due to Promise.all logic => simulated Promise.allSettled in UploadManager as es2017 does not have it.
@chetbae chetbae self-assigned this Jul 12, 2022
@chetbae chetbae merged commit 2e364bd into new-index-page Jul 12, 2022
@chetbae chetbae deleted the index-sample-feature branch July 12, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant