✨ Add MEI action for removing out of bounds glyphs #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ a check for out-of-bounds glyphs when the MEI is first loaded in
- Add 'default', 'error', 'warning', 'success' types - Set opacity to 1 for notifications - Add emojis for notifications :) - Changed a couple notifications to have these new types, not all of them though
yinanazhou
requested changes
Jul 18, 2022
There was a problem hiding this comment.
A few details need further adjustment:
- When the user open a folio, Neon should notify the user that the folio has out-of-bound glyphs (OOB), instead of has no OOB glyphs, so that the user can perform the remove action.
- When the folio has no OOB glyphs, Neon should notify the user that no OOB glyphs are found, instead of successful removal.
- Remove no out-of-bound glyphs notification for loading in the folio. - Add notification and return early if there are no out-of-bound glyphs during MEI action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a check for out-of-bounds glyphs when the MEI is first loaded in.
Fixes #920 .