🐛 Prevent cmd/ctrl+r from updating highlight #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to the new index page and reorganization of routes.
We have been using Jest and Selenium for e2e testing, but they have been broken since summer day 1! Since then, we've made so many breaking changes that the tests will just not work anymore. Now we have Cypress tests being used, so it makes sense that `yarn test` is replaced with the Cypress command.
The glyph opacity toggle button tests are skipped, as there is a bug that has not been fixed. @cadagong has fixed it on a different branch!
- Rename sliders.cy.ts --> opacity.cy.ts - Refactor main test code to simple function calls
I don't think we need cypress/downloads, since it just gives extra information when running Cypress tests.
To be fixed with #949
Test checks whether pressing cmd/ctrl + r to refresh the page has the unexpected consequence of setting layerElement as the highlight option.
Pressing q/w/e/r/t/y should change highlight options correctly
yinanazhou
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.