Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] user should not be able to add/delete ports beyond port minimum/maximum #857

Closed
jacobdgm opened this issue May 2, 2023 · 0 comments · Fixed by #907
Closed

[Client] user should not be able to add/delete ports beyond port minimum/maximum #857

jacobdgm opened this issue May 2, 2023 · 0 comments · Fixed by #907
Assignees
Labels
bug Rodan Client Issues pertaining to Rodan client

Comments

@jacobdgm
Copy link

jacobdgm commented May 2, 2023

In the "WorkflowJob Ports" dialog, there are "Min" and "Max" values for each of the input and output port types. Currently, if you already have one instance of a given input port with a Max of 1, Rodan Client allows you to add additional instances of the port. Similarly, it allows you to delete ports of a given type even if you are already at the minimum.

Ideally, the "Add"/"Delete" buttons would be greyed out if adding/deleting instances of the port would exceed a minimum/maximum.

@timothydereuse timothydereuse changed the title Rodan Client, Ports: user should not be able to add/delete ports beyond port minimum/maximum [Client] user should not be able to add/delete ports beyond port minimum/maximum May 2, 2023
@timothydereuse timothydereuse added the Rodan Client Issues pertaining to Rodan client label May 2, 2023
@jackyyzhang03 jackyyzhang03 self-assigned this May 22, 2023
@softcat477 softcat477 linked a pull request May 24, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Rodan Client Issues pertaining to Rodan client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants