-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use poetry for python dependency management #838
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchiller
force-pushed
the
python-dependency-management
branch
from
March 22, 2024 02:52
679d06e
to
68e8709
Compare
Collect static files in app container and pass to nginx container with a volume. This removes the need for python dependencies in the nginx container build.
jacobdgm
reviewed
Mar 26, 2024
jacobdgm
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about Poetry for my approval to carry any weight, but I've looked through it and there don't seem to be any egregious errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way Cantus Ultimus handles dependencies. In the process, it closes #734.
Change introduced:
poetry
package. These are now configured in thepyproject.toml
file and locked with thepoetry.lock
file. Adev
dependency group is introduced that includes python dependencies useful for development when installed outside theapp
container but unnecessary for deployment; these can now be standardized across development environments. The README is updated to account for these changes.app
container has been adjusted to account for the use ofpoetry
.nginx
container build in order to collect Django-managed static files to a location in that container. This PR removes the need for python in thenginx
container build process by collecting static files in theapp
container, and sharing them via a new volume with thenginx
container. As I result, I'm going to say this closes Optimize nginx container build #552. No other optimizations currently seem available.NOTE: The
django-extensions
(and by extension, its dependencyWerkzeug
) are in fact development dependencies, but need to be installed in theapp
container. I've opened #839 to address this at a later date.