Implement minor build fixes #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of solrpy shipped with an errant print statement, so we use the release tag on GitHub instead.
Rather than choosing a new, random secret key every container build, we pass the secret key in from environment variables.
Use .get in accessing RabbitMQ settings Add `django_extension` in INSTALLED_APPS only at debug
|
@lucasmarchd01 could you take a look? |
lucasmarchd01
approved these changes
May 31, 2024
| @@ -18,6 +18,7 @@ jobs: | |||
| RABBIT_USER: admin | |||
| RABBIT_PASSWORD: supersecurepassword99 | |||
| PORT: "8000" | |||
| DJANGO_SECRET_KEY: verygoodandsecurekey123456123465@@123456 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a number of relatively minor container building and configuration related fixes that I've been collecting while developing.
.envfile. This allows us to keep the same secret key across multiple container builds and also make use of django settings for linting and type checking in development.solrpyrunning around. The one on pypi had a very annoying extra print statement that clogged up the logs, while the release on thesolrpyrepository did not have that print statement. This PR switches those out in the python dependencies.psycopgbinary version to our dependencies, since we don't need to use the pure python implementation.PORTenvironment variable to signal when we were running in development mode to using a more aptly namedDEVELOPMENTvariable, but we didn't modify the rest of theappcontainer build process to properly make use of this new variable. We do that here.celeryapp was using some convoluted methods to get its settings. We simplify that in 9a21998