Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2023 group photo to front page #116

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Add 2023 group photo to front page #116

merged 2 commits into from
Jun 5, 2023

Conversation

zhannaklimanova
Copy link
Contributor

No description provided.

PythonSemicolon
PythonSemicolon reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@PythonSemicolon PythonSemicolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. I believe the old photo will need to be added to the archive at /people now (@fujinaga can you confirm this).
Can you also replace the image in the deforested branch as it is the deployed version?

@zhannaklimanova
Copy link
Contributor Author

zhannaklimanova commented Jun 5, 2023 •
edited
Loading

Looks ok. I believe the old photo will need to be added to the archive at /people now (@fujinaga can you confirm this). Can you also replace the image in the deforested branch as it is the deployed version?

Added photos to archive + deforested branch should also be updated. Review both please.

PythonSemicolon
PythonSemicolon approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@PythonSemicolon PythonSemicolon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can see changes on deforested and they appear as they should.

@PythonSemicolon PythonSemicolon mentioned this pull request Jun 5, 2023
Closed
@PythonSemicolon PythonSemicolon linked an issue Jun 5, 2023 that may be closed by this pull request
Add 2023 group photo to static website #117
Closed
@fujinaga
Copy link
Member

fujinaga commented Jun 5, 2023

Looks ok. I believe the old photo will need to be added to the archive at /people now (@fujinaga can you confirm this). Can you also replace the image in the deforested branch as it is the deployed version?

Added photos to archive + deforested branch should also be updated. Review both please.

Yes, I confirm.

@zhannaklimanova zhannaklimanova merged commit 1f78042 into master Jun 5, 2023
@zhannaklimanova zhannaklimanova deleted the new-group-photo branch June 5, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PythonSemicolon PythonSemicolon PythonSemicolon approved these changes

@fujinaga fujinaga Awaiting requested review from fujinaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 2023 group photo to static website
3 participants
@zhannaklimanova @fujinaga @PythonSemicolon