Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Fix bba async logic #157

Merged
merged 1 commit into from
Jul 9, 2019
Merged

fix : Fix bba async logic #157

merged 1 commit into from
Jul 9, 2019

Conversation

AgwaB
Copy link
Contributor

@AgwaB AgwaB commented Jul 4, 2019

Related Issue

Description

  • when raising round, need to follow one context. fix compare logic to channel.
  • when send delayed message, Bval should arrive first and Aux second.

Checklist

Thank you for your contribution.
Before submitting this PR, please make sure:

  • Applying goimports
  • Test case
  • End of Work

bba/bba.go Show resolved Hide resolved
bba/bba.go Outdated Show resolved Hide resolved
bba/bba.go Outdated Show resolved Hide resolved
bba/bba.go Outdated Show resolved Hide resolved
bba/bba.go Outdated Show resolved Hide resolved
bba/bba.go Outdated Show resolved Hide resolved
@AgwaB AgwaB force-pushed the fix/bba branch 2 times, most recently from e536453 to 2d4383a Compare July 9, 2019 12:50
test/mock/coin.go Outdated Show resolved Hide resolved
Copy link
Member

@zeroFruit zeroFruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@zeroFruit zeroFruit merged commit e38afd1 into DE-labtory:develop Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants