Skip to content

Commit 64bde66

Browse files
authoredJun 12, 2020
Fix issue in travis with bundler args (#19)
Problem: Back in May we started seeing a number of projects Travis builds failing. The error is: ``` $ gem install -v 1.17.3 bundler --no-rdoc --no-ri ERROR: While executing gem ... (OptionParser::InvalidOption) invalid option: --no-rdoc The command "gem install -v 1.17.3 bundler --no-rdoc --no-ri" failed and exited with 1 during . ``` Visible in https://travis-ci.com/github/DEFRA/defra-ruby-aws/builds/170472128 We think the only difference in the builds is the version of the ruby binary Travis is pulling. But for now, we are simply going to switch our args to move past the issue and get things building again. N.B. Includes some rubocop fixes flagged in latest version
1 parent 094c37f commit 64bde66

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
 

Diff for: ‎.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ git:
1616

1717
before_install:
1818
- export TZ=UTC
19-
- gem install -v 1.17.3 bundler --no-rdoc --no-ri
19+
- gem install -v 1.17.3 bundler --no-document
2020

2121
script:
2222
- bundle exec rubocop --format progress --format json --out rubocop-result.json

Diff for: ‎spec/features/upload_file_to_bucket_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ def configure_gem
3737
end
3838

3939
def stub_successful_request
40-
stub_request(:put, %r{https:\/\/bulk-test\.s3\.eu-west-1\.amazonaws\.com\/test-bucket-load\..+})
40+
stub_request(:put, %r{https://bulk-test\.s3\.eu-west-1\.amazonaws\.com/test-bucket-load\..+})
4141
end
4242

4343
def stub_failing_request
4444
stub_request(
4545
:put,
46-
%r{https:\/\/bulk-test\.s3\.eu-west-1\.amazonaws\.com\/test-bucket-load\..+}
46+
%r{https://bulk-test\.s3\.eu-west-1\.amazonaws\.com/test-bucket-load\..+}
4747
).to_return(
4848
status: 403
4949
)

0 commit comments

Comments
 (0)
Please sign in to comment.