Skip to content

Commit

Permalink
Fix issue in travis with bundler args (#19)
Browse files Browse the repository at this point in the history
Problem:

Back in May we started seeing a number of projects Travis builds failing.

The error is:

```
$ gem install -v 1.17.3 bundler --no-rdoc --no-ri
ERROR:  While executing gem ... (OptionParser::InvalidOption)
    invalid option: --no-rdoc
The command "gem install -v 1.17.3 bundler --no-rdoc --no-ri" failed and exited with 1 during .
```

Visible in https://travis-ci.com/github/DEFRA/defra-ruby-aws/builds/170472128

We think the only difference in the builds is the version of the ruby binary Travis is pulling. But for now, we are simply going to switch our args to move past the issue and get things building again.

N.B. Includes some rubocop fixes flagged in latest version
  • Loading branch information
Cruikshanks authored Jun 12, 2020
1 parent 094c37f commit 64bde66
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ git:

before_install:
- export TZ=UTC
- gem install -v 1.17.3 bundler --no-rdoc --no-ri
- gem install -v 1.17.3 bundler --no-document

script:
- bundle exec rubocop --format progress --format json --out rubocop-result.json
Expand Down
4 changes: 2 additions & 2 deletions spec/features/upload_file_to_bucket_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ def configure_gem
end

def stub_successful_request
stub_request(:put, %r{https:\/\/bulk-test\.s3\.eu-west-1\.amazonaws\.com\/test-bucket-load\..+})
stub_request(:put, %r{https://bulk-test\.s3\.eu-west-1\.amazonaws\.com/test-bucket-load\..+})
end

def stub_failing_request
stub_request(
:put,
%r{https:\/\/bulk-test\.s3\.eu-west-1\.amazonaws\.com\/test-bucket-load\..+}
%r{https://bulk-test\.s3\.eu-west-1\.amazonaws\.com/test-bucket-load\..+}
).to_return(
status: 403
)
Expand Down

0 comments on commit 64bde66

Please sign in to comment.