Bucket implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the buckets cofiguration and loading of a file to S3 AWS.
cintamani
commented
Jun 6, 2019
| end | ||
|
|
||
| def run | ||
| s3_bucket.object(File.basename(file.path)).upload_file(file.path, server_side_encryption: :AES256) |
There was a problem hiding this comment.
This is a temporary code. Will wrap it in a Response object that will deal with failures in a subsequent PR
Cruikshanks
approved these changes
Jun 6, 2019
cintamani
force-pushed
the
bucket-implementation
branch
from
d248696
to
fe0a57b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the configuration and loading of a file to S3 buckets.
This still needs proper end-to-end testing but is good to wrap it up now and fix later.