Update gemspec to match our other gems #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
force-pushed
the
make-gemspec-consistent
branch
from
9c0f28b
to
80f0151
Compare
This updates the gemspec file content and format to match that used in [Defra Ruby Style](https://github.com/DEFRA/defra-ruby-style) and [Defra Ruby Validators](https://github.com/DEFRA/defra-ruby-validators). Specific changes are - `spec.name` in our other gems is snake case rather than kebab case so updated to match - `spec.summary` and `spec.description` have been expanded - `spec.email` is set to @Cruikshanks. In lieu of a central mailbox anything Ruby based released to rubygems uses the @environment-agency.gov.uk address in case we receive any requests for info. We certainly can't use private email addresses - `spec.files` has switched from 'add files except' to be 'add only these files' - updated the `spec.respond_to?` to be consistent. Again don't know which is best, this change is just about consistency - dropped the explicit dev dependency for `rubocop`. It comes in via `defra_ruby_style` (though we seem to also declare it in `defra_ruby_validators` so that will be fixed asap as well!)
Cruikshanks
force-pushed
the
make-gemspec-consistent
branch
from
80f0151
to
e3c600f
Compare
|
Using my ⚡️POWERS⚡️ to merge this in so we can have a version released to Rubygems and ready for using next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the gemspec file content and format to match that used in Defra Ruby Style and Defra Ruby Validators. Specific changes are
$LOAD_PATHstatement at top of file. Don't actually know which is better, this change is just about consistencyspec.namein our other gems is snake case rather than kebab case so updated to matchspec.summaryandspec.descriptionhave been expandedspec.emailis set to @Cruikshanks. In lieu of a central mailbox anything Ruby based released to rubygems uses the @environment-agency.gov.uk address in case we receive any requests for info. We certainly can't use private email addressesspec.fileshas switched from 'add files except' to be 'add only these files'spec.respond_to?to be consistent. Again don't know which is best, this change is just about consistencyrubocop. It comes in viadefra_ruby_style(though we seem to also declare it indefra_ruby_validatorsso that will be fixed asap as well!)