Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to delete a file from a bucket #11

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Add ability to delete a file from a bucket #11

merged 3 commits into from
Sep 16, 2019

Conversation

cintamani
Copy link
Contributor

We want the ability to delete a file from an AWS bucket

@cintamani
Add ability to delete a file from a bucket
1bb6266 
We want the ability to delete a file from an AWS bucket
@cintamani cintamani added the enhancement New feature or request label Sep 13, 2019
@cintamani cintamani self-assigned this Sep 13, 2019
irisfaraway
irisfaraway reviewed Sep 16, 2019
View reviewed changes
Copy link
Member

@irisfaraway irisfaraway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some of my usual nitpicking :) But this looks good to me.

lib/defra_ruby/aws/response.rb Outdated Show resolved Hide resolved
lib/defra_ruby/aws/response.rb Outdated Show resolved Hide resolved
@cintamani @irisfaraway
Apply suggestions from code review
c4a67f6 
Co-Authored-By: Iris Faraway <iris.faraway@gmail.com>
@cintamani cintamani merged commit 94b63c8 into master Sep 16, 2019
@cintamani cintamani deleted the delete-file-from-bucket branch September 16, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cruikshanks Cruikshanks Cruikshanks approved these changes

@irisfaraway irisfaraway Awaiting requested review from irisfaraway

Assignees

@cintamani cintamani

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cintamani @Cruikshanks @irisfaraway