Temp. fix for cc-test-reporter & SimpleCov 0.18 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeclimate/test-reporter#418 On 28 Jan 2020 [SimpleCov 0.18.0](https://github.com/colszowka/simplecov/releases/tag/v0.18.0) was released. Though it's generating code coverage for us, its changed the JSON format of the `/coverage/.resultset.json` CodeClimate's [cc-test-reporter](https://github.com/codeclimate/test-reporter) appears to rely on. <details> <summary>Format before</summary> ```json { "RSpec": { "coverage": { "/path/to/my/file.rb": [ null, null, 1 ] }, "timestamp": 1580226312 } } ``` </details> <details> <summary>Format after</summary> ```json { "RSpec": { "coverage": { "/path/to/my/file.rb": { "lines": [ null, null, 1, null ], "branches": { } } }, "timestamp": 1580299988 } } ``` </details> When **cc-test-reporter** is called in the `after_script` hook in Travis-CI we are seeing the following error ```bash if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT; fi Error: json: cannot unmarshal object into Go struct field input.coverage of type []formatters.NullInt Usage: cc-test-reporter after-build [flags] Flags: -s, --batch-size int batch size for source files (default 500) -e, --coverage-endpoint string endpoint to upload coverage information to (default "https://api.codeclimate.com/v1/test_reports") -t, --coverage-input-type string type of input source to use [clover, cobertura, coverage.py, excoveralls, gcov, gocov, jacoco, lcov, simplecov, xccov] --exit-code int exit code of the test run -r, --id string reporter identifier (default "463a251defaae85271bff85ea8b1e58aa06cc9322157aa3ad7ee2a986aa13612") --insecure send coverage insecurely (without HTTPS) -p, --prefix string the root directory where the coverage analysis was performed (default "/home/travis/build/DEFRA/waste-carriers-front-office") Global Flags: -d, --debug run in debug mode ``` As the CodeClimate integration is important to our CI process, we have chosen to temporarily set the version of SimpleCov as 0.17.1 until the issue is resolved.
cintamani
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codeclimate/test-reporter#418
On 28 Jan 2020 SimpleCov 0.18.0 was released. Though it's generating code coverage for us, its changed the JSON format of the
/coverage/.resultset.jsonCodeClimate's cc-test-reporter appears to rely on.Format before
{ "RSpec": { "coverage": { "/path/to/my/file.rb": [ null, null, 1 ] }, "timestamp": 1580226312 } }Format after
{ "RSpec": { "coverage": { "/path/to/my/file.rb": { "lines": [ null, null, 1, null ], "branches": { } } }, "timestamp": 1580299988 } }When cc-test-reporter is called in the
after_scripthook in Travis-CI we are seeing the following errorAs the CodeClimate integration is important to our CI process, we have chosen to temporarily set the version of SimpleCov as 0.17.1 until the issue is resolved.