Add files and dependencies for deployment to Heroku #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodpigeon
force-pushed
the
feature/create_heroku_deployment
branch
from
4e55390
to
2691bcd
Compare
- Add rails_12factor gem for Heroku - Add Procfile - Add puma gem and config file - Rename set_page_title to page_title to resolve engine conflict - Remove failing spec until deployment resolved - Add an .env.test file for CI ENV vars - Add an initialiser to check ENV vars are present: Certain ENV vars must be set in the environment, whether we are deployed to Heroku or AWS. This initializer fails early if the ENV var is not set, to avoid a late failure for example if a setting for email host is not set - this would be discovered only when the first email is sent. See Trello board - this was a suggestion from RC after issues in WEX.
woodpigeon
force-pushed
the
feature/create_heroku_deployment
branch
from
2691bcd
to
8528ebe
Compare
|
puma not really my area of expertise but looks good to me, and heroku itself looking great so 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain ENV vars must be set in the environment,
whether we are deployed to Heroku or AWS. This initializer
fails early if the ENV var is not set, to avoid a late failure
for example if a setting for email host is not set - this
would be discovered only when the first email is sent.
See Trello board - this was a suggestion from RC after issues
in WEX.