Change after_hook error to use config not assume #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will resolve issue #41, which highlights that **Quke's** assumption that CI is only being when the **phantomjs** driver is selected is restrictive and incorrect. Users may wish to use other drivers in a CI environment, for example [XVFB](https://en.wikipedia.org/wiki/Xvfb) with Chrome. Therefore this change removes the assumption in the `after_hook.rb` logic to fail immediately if **phantomjs** is being used, to instead drive the behaviour of a config flag.
Rubocop is essentially flagging what appear to be appropriate or reasonable statements and methods in the spec files. To make it clear that these are accepted not just overlooked, this change updates `.rubocop.yml` to match how we have actually structured the specs.
Cruikshanks
force-pushed
the
feature/config-immediate-exit-do-not-assume
branch
from
112fc66
to
697d949
Compare
This update gets the documentation stat to 100%.
Cruikshanks
force-pushed
the
feature/config-immediate-exit-do-not-assume
branch
from
697d949
to
a388ac5
Compare
This was referenced Nov 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve issue #41, which highlights that Quke's assumption that CI is only being when the phantomjs driver is selected is restrictive and incorrect.
Users may wish to use other drivers in a CI environment, for example XVFB with Chrome. Therefore this change removes the assumption in the
after_hook.rblogic to fail immediately if phantomjs is being used, to instead drive the behaviour off a config flag.