Hide RCP option for Junior licence purchases #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-4066# Please enter the commit message for your changes. Lines starting
jaucourt
requested changes
Jul 9, 2024
packages/gafl-webapp-service/src/processors/__tests__/recurring-pay-helper.spec.js
Outdated
Show resolved
Hide resolved
packages/gafl-webapp-service/src/processors/__tests__/recurring-pay-helper.spec.js
Outdated
Show resolved
Hide resolved
packages/gafl-webapp-service/src/processors/recurring-pay-helper.js
Outdated
Show resolved
Hide resolved
jaucourt
requested changes
Jul 18, 2024
packages/gafl-webapp-service/src/processors/__tests__/recurring-pay-helper.spec.js
Outdated
Show resolved
Hide resolved
packages/gafl-webapp-service/src/processors/recurring-pay-helper.js
Outdated
Show resolved
Hide resolved
|
jaucourt
approved these changes
Aug 5, 2024
lailien3
added a commit
that referenced
this pull request
Sep 2, 2024
* Hide RCP option for Junior licence purchases https://eaflood.atlassian.net/browse/IWTF-4066# Please enter the commit message for your changes. Lines starting * Created tests * Fixed 'age' attribute and fixed comma position * Random space from test removed * Changed age condition * Replaced magic number with constant (SonarCloud suggesstion) * Removed unnecessary test * Removed unnecessary test * Used template literals & removed hardcoded age * Removed hardcoded age, and ensured respective tests passed * Implemented template literal * Corrected age calculation, corrected describve statement's grammar, subbed in birthDate > age * Replaces age field with birthDate field, and amended tests * Prettier fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-4066
Anglers under 17 y/o should not be offered the option to set up recurring payments, so it the option has been hidden.