Pay for a renewal by bank transfer #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WC-118 If a user chooses to pay by bank transfer on the Payment Summary page, they should be sent to an additional page which has all the necessary instructions, information and bank details for them to make the payment. This is instead of going through WorldPay. It should be made clear that paying by bank transfer means you cannot instantly renew your registration as you have to wait for your renewal to be processed.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
Add all the information about how to pay by bank transfer. The only thing missing is the total cost - we still need to calculate this and add it.
This had already been done in a separate branch: #145 but it made more sense to move it from the form into the transient_registration. This also involved renaming some existing methods in the transient_registration for clarity's sake.
Split addresses onto multiple lines so they are easier to read and the table is less squashed. Also add a line to clarify that the renewal isn't complete until both payment steps are done.
|
@Cruikshanks Think this is almost at review stage, but I'll hold off on requesting on until #145 is merged in as I'll need to make some changes after that. |
|
No worries. #145 has a couple of minor request for changes, but ready to approve and move onto this when you say so! |
Now that the payment summary form branch is merged in, we can update our routing tests. Also make some tweaks to how the charge information is stored.
Cruikshanks
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-118
If a user chooses to pay by bank transfer on the Payment Summary page, they should be sent to an additional page which has all the necessary instructions, information and bank details for them to make the payment.
This is instead of going through WorldPay.
It should be made clear that paying by bank transfer means you cannot instantly renew your registration as you have to wait for your renewal to be processed.
Somewhat reliant on #145
Note also that this doesn't cover progressing to the "renewal application received" page - that's covered by WC-120.