Refactor scope tests for consistency #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update our specs for transient_registration scopes so we are testing them in a consistent way.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
As these blocks describe the method, rather than the context in which it is being called.
Several scope specs were creating near-identical objects in the individual specs. We can reduce duplication by specifying these using `let`.
We can use any transient_registration with a unique reg_identifier to test this, so `in_progress_renewal` fits the bill.
This is a precursor to further refactoring, so we can test the expectations individually. Also add some extra expectations that the results include the test objects, rather than just checking the length.
Then test that the results include the matching object and do not include the non-matching one. Also a precursor to testing expectations separately.
Use `let` to define the scope we are testing once, just inside the `describe` block. This means the individual specs have less duplication and are easier to read.
As we did with the filters, define the scope for `search_term` using a `let` block right inside the `define` block. We provide a default for term, but can use additional `let` blocks to modify this depending on the context.
This means we can run tests at a more granular level, and means the format is more consistent with our other scope tests.
A minor reordering, but makes the tests a bit easier to read.
Cruikshanks
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our specs for transient_registration scopes so we are testing them in a consistent way.
This came from a discussion on #304 (review)