Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Thermo Interface #55

Merged
merged 6 commits into from
May 7, 2021
Merged

New Thermo Interface #55

merged 6 commits into from
May 7, 2021

Conversation

TJP-Karpowski
Copy link
Contributor

Hi,
here the thermo Interface. So far all functions take the same arguments although X and p is not always required.

jiweiqi
jiweiqi approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@jiweiqi jiweiqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code looks nice to me. I like the meta-programming, which looks clean. The @autodoc is also great.

@jiweiqi jiweiqi merged commit 03e31ea into DENG-MIT:main May 7, 2021
@jiweiqi
Copy link
Member

jiweiqi commented May 7, 2021

#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiweiqi jiweiqi jiweiqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TJP-Karpowski @jiweiqi