Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEVA-2033] Apply CTA Application Status #3053

Merged
merged 2 commits into from
Mar 16, 2021
Merged

[TEVA-2033] Apply CTA Application Status #3053

merged 2 commits into from
Mar 16, 2021

Conversation

josephhull676
Copy link
Contributor

@josephhull676 josephhull676 commented Mar 10, 2021 •
edited
Loading

Jira ticket URL

https://dfedigital.atlassian.net/browse/TEVA-2033

Changes in this PR:

  • Different values passed in to the button link component depending on the status of a jobseekers' application
  • 'Apply for job' link now only rendered if the school have indicated that they would like jobseekers to be able to apply through teaching vacancies
  • 'Save job' button link now only rendered if the jobseeker has not applied for the job

Screenshots of UI changes:

Jobseeker not signed in

Screenshot 2021-03-10 at 16 13 31

Jobseeker Signed in

No Application

Screenshot 2021-03-10 at 16 14 29

Application in draft

Screenshot 2021-03-10 at 16 18 58

Application submitted

Screenshot 2021-03-10 at 16 23 54

@josephhull676 josephhull676 force-pushed the TEVA-2033-apply-CTA-application-status branch from 85390f2 to 33fae8d Compare March 10, 2021 16:32
@martin-bangoura
Copy link

Review app deployed to https://teaching-vacancies-review-pr-3053.london.cloudapps.digital

cpjmcquillan
cpjmcquillan reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@cpjmcquillan cpjmcquillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really how we want to use components in an ideal world.

I don't think it needs to be as complicated as this - do you want to organise some time to pair on it?

@josephhull676
Copy link
Contributor Author

This isn't really how we want to use components in an ideal world.

I don't think it needs to be as complicated as this - do you want to organise some time to pair on it?

Yes please lol

@josephhull676 josephhull676 force-pushed the TEVA-2033-apply-CTA-application-status branch 2 times, most recently from 1e3ab61 to 5b30661 Compare March 11, 2021 17:09
@josephhull676
Add green tick icon
0988f02
@josephhull676
Add checks for job application presence and status
d7437c8 
Checks render different banner link components depending on the presence and status of a job application. Save job link not rendered if a job application exists
@josephhull676 josephhull676 force-pushed the TEVA-2033-apply-CTA-application-status branch from 5b30661 to d7437c8 Compare March 11, 2021 17:46
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josephhull676 josephhull676 merged commit 28e8fac into master Mar 16, 2021
@josephhull676 josephhull676 deleted the TEVA-2033-apply-CTA-application-status branch March 16, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpjmcquillan cpjmcquillan cpjmcquillan left review comments

@cesidio cesidio cesidio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephhull676 @martin-bangoura @cesidio @cpjmcquillan