Add new ASR landing pages #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app https://teaching-vacancies-review-pr-6829.test.teacherservices.cloud was successfully deleted |
ddippolito
force-pushed
the
ASR-new-job-role-urls
branch
from
b379717
to
213fecf
Compare
ddippolito
force-pushed
the
ASR-new-job-role-urls
branch
from
1868bd7
to
1aa4d55
Compare
ddippolito
force-pushed
the
ASR-new-job-role-urls
branch
from
1aa4d55
to
c5b73d0
Compare
ddippolito
commented
May 2, 2024
config/locales/landing_pages.yml
Outdated
| name: "Other teaching support" | ||
| title: "Other Teaching Support Jobs" | ||
| heading: "%{count} other teaching support jobs" | ||
| meta_description: "" |
There was a problem hiding this comment.
@scruti I've purposely left these empty. Who do we need to ask for the content here?
There was a problem hiding this comment.
tried to update the meta descriptions - seem to have broken things 🙃
(very sorry - and will also be offline at training all day today so am literally just leaving you to deal with my mess ... 🤦♀️)
scruti
approved these changes
May 2, 2024
think I might've accidentally just deleted this 🤦♀️
ddippolito
force-pushed
the
ASR-new-job-role-urls
branch
from
f264d20
to
9639e79
Compare
ddippolito
force-pushed
the
ASR-new-job-role-urls
branch
from
d77460d
to
236889a
Compare
ddippolito
force-pushed
the
ASR-new-job-role-urls
branch
from
6b68daf
to
26edcfb
Compare
ddippolito
force-pushed
the
ASR-new-job-role-urls
branch
from
26edcfb
to
f819c1e
Compare
config/locales/en.yml
Outdated
| @@ -175,7 +175,7 @@ en: | |||
| jobs_by_school_type_and_role: Jobs by type of school and role | |||
| jobs_by_subject: Teaching jobs by subject | |||
| working_patterns: Working patterns | |||
| teaching_roles: Teaching roles | |||
| teaching_roles: Teaching roles & leadership roles | |||
There was a problem hiding this comment.
I think this should be "Teaching & leadership roles"
ddippolito
force-pushed
the
ASR-new-job-role-urls
branch
from
f819c1e
to
413327b
Compare
KyleMacPherson
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/m5hu2imW/844-asr-new-job-role-urls-add-to-home-page
https://trello.com/c/l7joSnX6/996-tweak-asr-urls
Changes in this PR:
Add new ASR landing pages.
Before the changes in this PR:
After the changes in this PR: