Upgrade and enable rubocop rspec #6920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruti
force-pushed
the
upgrade-and-enable-rubocop-rspec
branch
from
7fe70ee
to
3fe65d9
Compare
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.31.0 to 3.0.1. - [Release notes](https://github.com/rubocop/rubocop-rspec/releases) - [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rspec@v2.31.0...v3.0.1) --- updated-dependencies: - dependency-name: rubocop-rspec dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Rubocop Rspec Capybara, FactoryBot and Rails specific code have been extracted from the main rubocop-rspec gem. Adding the external extensions to keep the behaviour with the upgrade to rubocop-rspec v3.
So Dependabot will group rspec or govuk gem related upgrades into a single PR.
It was disabled on the rubocop config So no cops were running over the test files.
scruti
force-pushed
the
upgrade-and-enable-rubocop-rspec
branch
from
3fe65d9
to
588f0fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
Changes in this PR:
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?