[quickfort] fix rare crash in buildingplan when switching ui modes #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by manually changing df.global.ui.main.mode we skipped validity checking the ui normally does on state change. this sometimes resulted in bad data in world->selected_building, which caused buildingplan to crash. using the UI to switch modes avoids this problem.
lethosor
approved these changes
Jan 29, 2021
internal/quickfort/query.lua
Outdated
| -- send keycodes to exit the current UI sidebar mode and enter another one with | ||
| -- the given keycode. we verify before calling this function that we are in a | ||
| -- mode that can be exited with one press of ESC. | ||
| local function switch_ui_sidebar_mode(mode_keycode) |
There was a problem hiding this comment.
I would probably make this take a sidebar mode instead of a keycode (I think that would just require moving valid_ui_sidebar_modes above this function), but it works this way too.
There was a problem hiding this comment.
Good suggestion. I'll make that change.
instead of a keycode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DFHack/dfhack#1762
by manually changing df.global.ui.main.mode we skipped validity checking the ui normally does on state change. this sometimes resulted in bad data in world->selected_building, which caused buildingplan to crash. using the UI to switch modes avoids this problem.