-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add options to autonick #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
requested changes
Mar 28, 2022
myk002
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than one minor nit, looks good! could you add a changelog entry?
edit: ok two minor nits. the changelog entry request counts as a nit
hopefully this looks ok now. |
missed a couple backticks, whoops! hopefully this should be all good now, for real this time |
myk002
reviewed
Mar 29, 2022
myk002
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
three real changes, whoops.
add a dialogue to confirm that the user actually wants to nickname, suppressable with -f / --forcerequire the use of the commandall
to proceed, egautonick all
. together with 1, this resolves autonick does not listen for "help" or "-help" args dfhack#2050.something that might be nice (but that i haven't done yet) is to raise an error if the user is not in fort mode, since it doesn't really make sense to run it anywhere else.
another possible improvement would be to assume -f if no console exists, so existing configs don't break.