Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeown] fix field names changed in structures update #959

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

myk002
Copy link
Member

@myk002 myk002 commented Jan 26, 2024

@myk002
Copy link
Member Author

myk002 commented Jan 26, 2024

this highlights a code best practice: prefer {new=true} to df.longtypename.T_whatever:new() so code doesn't break when types are renamed

@myk002 myk002 merged commit f606e94 into DFHack:master Jan 26, 2024
10 checks passed
@myk002 myk002 deleted the myk_whereabouts branch January 26, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant