Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #1292 #1293

Merged
merged 4 commits into from
Nov 8, 2017
Merged

Fix issue #1292 #1293

merged 4 commits into from
Nov 8, 2017

Conversation

JacquesOlivierLachaud
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud commented Nov 7, 2017 •
edited
Loading

Thanks a lot for contributing to DGtal, before submitting your PR, please fill up the description and make sure that all checkboxes are checked. Please remove these lines in your PR.

PR Description

Fix #1292 , build error with clang++ and GMP in package arithmetic.

Checklist

  • [NA] Unit-test of your feature with Catch.
  • [NA] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [NA] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

dcoeurjo
dcoeurjo requested changes Nov 8, 2017
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix.

src/DGtal/arithmetic/ModuleSRC.txt Outdated
DGtal/arithmetic/SternBrocot
DGtal/arithmetic/LightSternBrocot
DGtal/arithmetic/LighterSternBrocot)
## SET(DGTAL_SRC ${DGTAL_SRC} ... )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could just remove this file..

@JacquesOlivierLachaud
Copy link
Member Author

Ok. Done.

@dcoeurjo
Copy link
Member

dcoeurjo commented Nov 8, 2017

thx.. waiting for the bots and I merge.

@dcoeurjo
Copy link
Member

dcoeurjo commented Nov 8, 2017

Thanks merging

@dcoeurjo dcoeurjo merged commit 4e0d4ae into DGtal-team:master Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

Assignees
No one assigned
Labels
Arithmetic ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacquesOlivierLachaud @dcoeurjo