Device definitions sync tableland #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorranSutter
commented
May 17, 2024
JamesReate
reviewed
May 20, 2024
scripts/tableland/tasks.ts
Outdated
| // delete dd | ||
| let deleteDeviceDefinitionByManufacturers = []; | ||
| deviceDefinitionByManufacturers.forEach(element => { | ||
| const dds = tablelandDeviceDefinitionByManufacturers.filter((c) => c.ksuid === element.device_definition_id); |
There was a problem hiding this comment.
hmm actually I think this should be the other way around:
- iterate over tableland defs
- for each lookup in deviceDefinitions
- if not found, delete from tableland.
There was a problem hiding this comment.
I mean I guess this would work, and is accounting for differences in the id to delete. But there are certain scenarios where i think we wouldn't be deleting
JamesReate
reviewed
May 21, 2024
LorranSutter
commented
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.