Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLA-1116 - Create RegisterUserDeviceFromVIN endpoint #28

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

rhvivancoeffio
Copy link
Contributor

Proposed Changes

Impacted Packages

Caveats

@rhvivancoeffio rhvivancoeffio requested a review from a team as a code owner March 13, 2023 21:18
@linear
Copy link

linear bot commented Mar 13, 2023

PLA-1116 Admin tool - User Device - create from VIN

as dimo support, want to allow people with old non BT devices to still be able to switch cars / re-pair their device, so that we have a smooth experience with new VIN based pairing.

Background:

We are changing the pairing flow so that a VIN is required upon initial pairing. The vin can only be obtained from autopi's with BT. There may be edge cases where autopi cannot get vin too. Therefore we need easy way for support to handle these.

Solution:

In admin tool, under User details screen, add button to "add a user device from vin", then in this screen support person can enter the user's VIN and system creates a user device from the VIN by decoding. Essentialy does the same logic as this endpoint: https://github.com/DIMO-Network/devices-api/blob/5334a647bf2154ddd33db6c6e29b3ca71def6e13/internal/controllers/user_devices_controller.go#L463-L491

Acceptance:

  • grpc endpoint in devices-api that can be called by admin tool
  • devices-api endpoint takes in vin and userId, then does same logic as above codel
  • screen changes in admin user details view
  • new screen for create by vin

@rhvivancoeffio rhvivancoeffio merged commit 2b91be2 into main Mar 13, 2023
@rhvivancoeffio rhvivancoeffio deleted the shared-register-user-device-from-vin branch March 13, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants