Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLA-1068 - Remove device-api grpc. #33

Merged
merged 1 commit into from
Apr 4, 2023
Merged

PLA-1068 - Remove device-api grpc. #33

merged 1 commit into from
Apr 4, 2023

Conversation

rhvivancoeffio
Copy link
Contributor

Proposed Changes

Impacted Packages

Caveats

@rhvivancoeffio rhvivancoeffio requested a review from a team as a code owner March 23, 2023 15:09
@linear
Copy link

linear bot commented Mar 23, 2023

PLA-1068 Move devices-api grpc from shared to actual repo

as dimo eng, want grpc to be in same repo as one exposing the endpoints, to make development easier.

Acceptance

  • follow example from device-definitions-api - look at pkg folder
  • Update readme
  • Update references that point to shared to instead point to local pkg grpc protos
  • Push a PR and once merged make a release
  • Update other projects that use, eg. device-definitions, admin, vehicle-signal-decoding, others, to point instead of at shared to the devices-api protos.
  • Create separate story to delete protos from shared.

JamesReate
JamesReate approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@JamesReate JamesReate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will let people know before merging

@JamesReate JamesReate merged commit 6dff523 into main Apr 4, 2023
@JamesReate JamesReate deleted the shared-remove-device-api-grpc branch April 4, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesReate JamesReate JamesReate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhvivancoeffio @JamesReate @ricardovivanco