Add norm correction along with data and methods to analyze norm discrepancies #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstagni
reviewed
Oct 29, 2021
fstagni
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #3 and includes:
score-analysis:DB12Analysis.ipynba jupyter notebook to analyze discrepancies between python2 and python3 executions.resourcesto generate and use further data in the analysis, this will be needed to updatedb12in the future.README.mdto get details about how to get data and run the analysis.src/db12/benchmark.get_norm_correction(): method intending to transform a python3 score into a python2 one.src/db12/factors.json: a json file containing the factors to apply to the score to effectively transform a score.