Exclude packages when building MacOS distribution #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
reviewed
Aug 25, 2021
scripts/make_release.py
Outdated
| @@ -20,6 +20,8 @@ | |||
| "linux-64": "Linux-x86_64", | |||
| "linux-aarch64": "Linux-aarch64", | |||
| "linux-ppc64le": "Linux-ppc64le", | |||
| "osx-64": "Darwin-x86_64", | |||
| "osx-arm64": "Darwin-arm64" | |||
There was a problem hiding this comment.
Suggested change
| "osx-arm64": "Darwin-arm64" | |
| # "osx-arm64": "Darwin-arm64" |
.github/workflows/build-and-test.yml
Outdated
| @@ -22,7 +22,7 @@ jobs: | |||
| shell: bash -l {0} | |||
| strategy: | |||
| matrix: | |||
| target_arch: ["linux-64", "linux-aarch64", "linux-ppc64le"] | |||
| target_arch: ["linux-64", "linux-aarch64", "linux-ppc64le", "osx-arm64", "osx-64"] | |||
There was a problem hiding this comment.
Looks like I'll have to take a look at arm64 but we can add just intel macs for now:
Suggested change
| target_arch: ["linux-64", "linux-aarch64", "linux-ppc64le", "osx-arm64", "osx-64"] | |
| target_arch: ["linux-64", "linux-aarch64", "linux-ppc64le", "osx-64"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
FIX: excludes several packages from building the MacOS distribution
CHANGE: add MacOS platforms for the building process
ENDRELEASENOTES