Set conda virtual packages correctly and add basic macOS tests #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure the failure is not due to these changes? |
chrisburr
reviewed
Oct 28, 2022
|
I'm confused by this pull request, adding the CI for testing the macOS installer is nice though it seems to have started with removing ipython? A few hours ago the macOS installer was happily built with it included: https://github.com/DIRACGrid/DIRACOS2/actions/runs/3342657994 |
|
Ah sorry I hadn't understood the PR description, I see the problem |
chrisburr
force-pushed
the
andresailer-patch-1
branch
from
111116c
to
d3864e4
Compare
|
To give a very abridged summary of the issue: |
chrisburr
changed the title
|
Thanks for the proper fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no ipython for macos?
cf. https://github.com/andresailer/InstallDiracTests/actions/runs/3343409709/jobs/5536598429#step:3:260
I hope this is the proper fix?BEGINRELEASENOTES
FIX: Fix ipython for macOS
NEW: CI add checks for macOS installers
ENDRELEASENOTES