Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect requirements.txt for container builds if it is provided #191

Merged

Conversation

ericblau
Copy link
Collaborator

put "--requirement requirements.txt" in dependencies if there is a
requirements.txt listed in the model metadata

requirements.txt listed in the model metadata
@coveralls
Copy link

coveralls commented May 15, 2023

Pull Request Test Coverage Report for Build 4985316620

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.812%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dlhub_sdk/utils/publish.py 6 7 85.71%
Totals Coverage Status
Change from base Build 4966370856: 0.02%
Covered Lines: 1811
Relevant Lines: 2241

💛 - Coveralls

Copy link
Contributor

@ascourtas ascourtas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from here! Note that tests will probably fail after this due to ongoing container service issues, but that's not due to anything in this PR

@ascourtas ascourtas merged commit 66b9fd5 into master May 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants