-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to gym 0.26 #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks =) will merge once new SB3 version is released
and thanks for the typo correction!
@araffin the first tutorial is not yet updated as it depends on the VideoRecorder. Furthermore I'm not sure if it is always clear that gym has a new API but that SB3 still uses the old API for it's VecEnv (could be confusing). Also VScode appears to change a whole lot of meta data, not sure how to fix that though. |
I see. Well, SB3 VecEnv uses its own API, the input/outputs/behavior are anyway different from single gym Env. Tell me if there are specific parts that I should take a look at.
no worry about that, I'll probably clean that up when I'll try the notebooks on colab |
@tlpss could you work on that? |
Yes, will take a look in the next days! |
I actually made recording video work in DLR-RM/rl-baselines3-zoo#256, so it might work now. |
I'm waiting for the render API changes to get merged, to make sure it will work on the lastest VecEnv api |
I think that the only thing missing is testing in google colab + pointing to the doc for gym API vs VecEnv API |
Notebooks checked with SB3 at the current state of PR - DLR-RM/stable-baselines3#780
To be merged only after next SB3 release that uses gym 0.23.1.
codespell
.