Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gym 0.26 #13

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Update to gym 0.26 #13

merged 5 commits into from
Apr 14, 2023

Conversation

arjun-kg
Copy link
Contributor

Notebooks checked with SB3 at the current state of PR - DLR-RM/stable-baselines3#780
To be merged only after next SB3 release that uses gym 0.23.1.

  1. Tiny change with seed being set in env.reset() instead of env.seed() to suppress a deprecation warning.
  2. Fixed typos with codespell.
  3. Left an existing Monitor wrapper warning alone (when eval env is not wrapper with Monitor) since it's a simple example.

Copy link
Owner

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =) will merge once new SB3 version is released

and thanks for the typo correction!

@tlpss
Copy link
Contributor

tlpss commented Oct 20, 2022

@araffin the first tutorial is not yet updated as it depends on the VideoRecorder. Furthermore I'm not sure if it is always clear that gym has a new API but that SB3 still uses the old API for it's VecEnv (could be confusing).

Also VScode appears to change a whole lot of meta data, not sure how to fix that though.

@araffin araffin changed the title Suppress warning after update to gym 0.23.1, fix typos Update to gym 0.26 Oct 20, 2022
@araffin
Copy link
Owner

araffin commented Oct 20, 2022

Furthermore I'm not sure if it is always clear that gym has a new API but that SB3 still uses the old API for it's VecEnv (could be confusing).

I see. Well, SB3 VecEnv uses its own API, the input/outputs/behavior are anyway different from single gym Env.
It should be ok as long as we explicitly mention when we use vec env or not.

Tell me if there are specific parts that I should take a look at.

Also VScode appears to change a whole lot of meta data, not sure how to fix that though.

no worry about that, I'll probably clean that up when I'll try the notebooks on colab

@araffin
Copy link
Owner

araffin commented Oct 31, 2022

first tutorial is not yet updated as it depends on the VideoRecorder.

@tlpss could you work on that?

@tlpss
Copy link
Contributor

tlpss commented Oct 31, 2022

@tlpss could you work on that?

Yes, will take a look in the next days!

@araffin
Copy link
Owner

araffin commented Oct 31, 2022

Yes, will take a look in the next days!

I actually made recording video work in DLR-RM/rl-baselines3-zoo#256, so it might work now.

@tlpss
Copy link
Contributor

tlpss commented Nov 5, 2022

Yes, will take a look in the next days!

I actually made recording video work in DLR-RM/rl-baselines3-zoo#256, so it might work now.

I'm waiting for the render API changes to get merged, to make sure it will work on the lastest VecEnv api

@araffin
Copy link
Owner

araffin commented Jan 5, 2023

I think that the only thing missing is testing in google colab + pointing to the doc for gym API vs VecEnv API

@araffin araffin merged commit 47cca25 into araffin:sb3 Apr 14, 2023
@araffin araffin deleted the gym0.23.1 branch April 14, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants