Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize data base in backend with four aggregated compartments #313

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

annawendler
Copy link
Contributor

@annawendler annawendler commented Oct 10, 2023

Description

We want to only display four (aggregated) compartments on the ESID frontend for the fall data that are uploaded via the automated workflow. For this, we need to initialize the backend with only four compartments. This has been adapted here.

Related Issues

Closes #312

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Unit Test Results

  1 files  ±0  14 suites  ±0   30s ⏱️ +7s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ±0 
33 runs  ±0  33 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 379fe47. ± Comparison against base commit eed53b2.

♻️ This comment has been updated with latest results.

@annawendler annawendler merged commit d3d830b into develop Oct 11, 2023
8 checks passed
@annawendler annawendler deleted the database-with-four-compartments branch October 11, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Initialize data base in backend with four aggregated compartments
2 participants