Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Searchbar Component #59

Merged
merged 12 commits into from
Dec 15, 2021
Merged

Update Searchbar Component #59

merged 12 commits into from
Dec 15, 2021

Conversation

NXXR
Copy link
Collaborator

@NXXR NXXR commented Nov 30, 2021

Updated the Searchbar component to be able to search and select districts.

@NXXR NXXR requested a review from JonasGilg November 30, 2021 17:02
@NXXR NXXR linked an issue Nov 30, 2021 that may be closed by this pull request
3 tasks
@github-actions
Copy link

github-actions bot commented Nov 30, 2021

Unit Test Results

  1 files  ±0  10 suites  ±0   21s ⏱️ +2s
19 tests +3  19 ✔️ +3  0 💤 ±0  0 ±0 

Results for commit de0adff. ± Comparison against base commit c0a83d9.

♻️ This comment has been updated with latest results.

@NXXR NXXR mentioned this pull request Dec 1, 2021
Copy link
Collaborator

@JonasGilg JonasGilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't search for "Germany" or "Deutschland" in the search bar.

frontend/src/components/Sidebar/SearchBar.tsx Outdated Show resolved Hide resolved
frontend/src/components/Sidebar/SearchBar.tsx Outdated Show resolved Hide resolved
@JonasGilg
Copy link
Collaborator

I would also prefer if the selected district name would be the placeholder text, like "Favorites" in this example: https://mui.com/components/autocomplete/#fixed-options.

If it is the real text it behaves very strange.

@NXXR NXXR mentioned this pull request Dec 13, 2021
3 tasks
@NXXR NXXR requested a review from JonasGilg December 14, 2021 17:41
Copy link
Collaborator

@JonasGilg JonasGilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and feels great. After you made the last change, you can merge.

frontend/src/components/Sidebar/SearchBar.tsx Show resolved Hide resolved
@NXXR NXXR merged commit 28e731e into main Dec 15, 2021
@NXXR NXXR deleted the feature/searchbar branch December 15, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search by region feature
2 participants