Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiglWingGetSegmentEtaXsi ignores GetPointBehavior #808

Closed
rainman110 opened this issue Jun 8, 2021 · 0 comments · Fixed by #811
Closed

tiglWingGetSegmentEtaXsi ignores GetPointBehavior #808

rainman110 opened this issue Jun 8, 2021 · 0 comments · Fixed by #811
Labels
bug Priority-High

Comments

@rainman110
Copy link
Collaborator

Currently, the function only use "onLinearLoft". If GetPointBehavior is switched to "as parameter on loft", we should use the upper/lower surface to retrieve point parameters.
rainman110 added a commit that referenced this issue Jun 16, 2021
@rainman110
Respect PointBehaviour for tiglWingGetSegmentEtaXsi
1833e84 
I had to change the class structure / method signature slightly
to allow to pass, how GetEtaXsi is evaluated.

Unfortunately, GetEtaXsi on the paramter surfaces is almost
a factor of thousand slower, which could be a problem for the
VTK export with metadata. Therefore I decided to use the old
eta / xsi interpretation for the exports for now.

To validate, I changed the consistency test, added a performance
test and added a function to tiglviewer to play around with
the function.

closes #808
@rainman110 rainman110 mentioned this issue Jun 16, 2021
Merged
5 tasks
@rainman110 rainman110 mentioned this issue Nov 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Priority-High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect PointBehaviour for tiglWingGetSegmentEtaXsi DLR-SC/tigl
1 participant
@rainman110