-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPACS files with patch version are not processed #830
Milestone
Comments
The problem does not only exist in the cpacs schema (which was actually fixed for tigl) but also here in the tigl code: https://github.com/DLR-SC/tigl/blob/master/src/api/tigl.cpp#L166 ReturnCode tixiRet = tixiGetDoubleElement(tixiHandle, "/cpacs/header/cpacsVersion", &dcpacsVersion);
if (tixiRet != SUCCESS) {
// NO CPACS Version Information in Header
if (tixiRet == ELEMENT_PATH_NOT_UNIQUE) {
LOG(ERROR) << "Multiple CPACS version entries found. Please verify CPACS file.";
}
else if (tixiRet == ELEMENT_NOT_FOUND) {
LOG(ERROR) << "No CPACS version information in file header. CPACS file seems to be too old.";
}
else {
LOG(ERROR) << "Cannot read CPACS version,";
}
return TIGL_WRONG_CPACS_VERSION;
}
else {
if (dcpacsVersion < (double) TIGL_MAJOR_VERSION) {
LOG(ERROR) << "Too old CPACS dataset. CPACS version has to be at least " << (double) TIGL_MAJOR_VERSION << "!";
return TIGL_WRONG_CPACS_VERSION;
}
else if (dcpacsVersion > atof(tiglGetVersion())) {
LOG(WARNING) << "CPACS dataset version is higher than TIGL library version!";
}
}
} |
rainman110
added a commit
that referenced
this issue
Nov 2, 2021
rainman110
added a commit
that referenced
this issue
Nov 2, 2021
rainman110
added a commit
that referenced
this issue
Nov 2, 2021
rainman110
added a commit
that referenced
this issue
Nov 2, 2021
Nice fix. Edit: never mind (my previous post), it's restricted to the corresponding release version anyway... sorry Thanks for the fix. |
rainman110
added a commit
that referenced
this issue
Nov 3, 2021
I also added more tests that check for valid and invalid semantic versions. Addresses #830
rainman110
added a commit
that referenced
this issue
Nov 4, 2021
rainman110
added a commit
that referenced
this issue
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we have a CPACS version with patch number, the dataset will not open:
basicWing.zip
The text was updated successfully, but these errors were encountered: