Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetFaceUV is not stable --> Some cells cannot be generated #840

Closed
joergbrech opened this issue Oct 6, 2021 · 1 comment · Fixed by #841
Closed

GetFaceUV is not stable --> Some cells cannot be generated #840

joergbrech opened this issue Oct 6, 2021 · 1 comment · Fixed by #841
Milestone

Comments

@joergbrech
Copy link
Contributor

We recently hat performance issues with the cell geometry generation, because the cell geometries were always cut, even when the resulting shape is just a trimmed surface. For this reason, even if the cell borders are not defined using contour coordinates, it is first checked if the cell can be trimmed rather than cut. To do this we project the corner points defined on the chordface onto the wing shell and identify the associated face and (u,v) coordinate on that point. This fails sometimes.

In this case, we should not throw an error, but fall back to the cutting algorithm.

@joergbrech
Copy link
Contributor Author

@hardt-fa-flb, pinging you here.

joergbrech added a commit that referenced this issue Oct 6, 2021
@joergbrech joergbrech mentioned this issue Oct 6, 2021
5 tasks
@rainman110 rainman110 added this to the TiGL 3.2.2 milestone Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants