This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Implement api_get_transaction_msg #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Dec 30, 2018
serializer/serializer.c
Outdated
| int ta_get_transaction_msg_res_serialize( | ||
| char** obj, const ta_get_transaction_msg_res_t* const res) { | ||
| cJSON* json_root = cJSON_CreateObject(); | ||
| char trytes_out[NUM_TRYTES_SIGNATURE + 1]; |
There was a problem hiding this comment.
trytes_out is the tryte string of res->msg which is trits, I'll rename it for better readability.
wusyong
approved these changes
Dec 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #31