Fix prefs category loading. #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a category, don't also create UI for the subcategories. This is weird and doesn't make sense, and is also the reason we needed the hacky NoRemovePanel. Previously, we added a category, then created a new panel for each of its subcategories. When you clicked on the subcat we made it again with a new panel, and the component ended up on both (because it couldn't be removed from the old one).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a category, don't also create UI for the subcategories.
This is weird and doesn't make sense, and is also the reason we
needed the hacky NoRemovePanel.
Previously, we added a category, then created a new panel for
each of its subcategories. When you clicked on the subcat
we made it again with a new panel, and the component ended
up on both (because it couldn't be removed from the old one).