Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email on completion of review only rather than one per comment #2059

Closed
jessn-h opened this issue Feb 25, 2019 · 11 comments
Closed

Send email on completion of review only rather than one per comment #2059

jessn-h opened this issue Feb 25, 2019 · 11 comments
Assignees

Comments

@jessn-h
Copy link

jessn-h commented Feb 25, 2019

Is it possible to change settings at an institution level so that DMP owners only receive an email upon completion of the review rather than one email per comment?

We have received feedback the some DMP owners feel the number of emails they receive is unnecessary.

@briri
Copy link
Contributor

briri commented Feb 25, 2019

Hi @jessn-h. The system currently does not have a way to distinguish between comments made to a plan by a reviewer and those made by collaborators.

Users do have the ability to turn off certain types of email notifications in their user profile (see screenshot below). If they deactivate the 'A new comment has been added to my DMP' option they will stop receiving those notices but will still be notified when the review period is over.
screen shot 2019-02-25 at 9 21 57 am

While not ideal, I hope it can at least help reduce the volume of communications your users are receiving from the tool.

@jessn-h
Copy link
Author

jessn-h commented Feb 26, 2019

Thanks @briri I thought that may be the case but just wanted to check I hadn't missed something. We will advise DMP owners to amend their notification settings.

@briri
Copy link
Contributor

briri commented Feb 26, 2019

thanks @jessn-h. I will leave this ticket in our backlog because I think it may be worth distinguishing between these types of comments at some point.

@sjDCC
Copy link
Contributor

sjDCC commented Mar 5, 2019

Yes, agree it would be good to distinguish between these @briri

One quick fix in interim could be to set the email notifications for plan comments as off automatically so it's opt-in rather than opt-out

@johnpinto1 johnpinto1 self-assigned this Mar 11, 2019
johnpinto1 added a commit that referenced this issue Mar 11, 2019
…ed to my DMP" is unticked for new users to the system:

 - The branding.yml will need to be altered to set the following item to false:
        preferences:
          email:
            users:
              new_comment: false

Fix for issue #2059
@johnpinto1
Copy link
Contributor

@briri + @xsrust
The branding.yml will need to be altered to set the following item to false:

preferences:
      email:
          users:
              new_comment: false

@sjDCC Only a new user will have the chekbox 'A new comment has been added to my DMP' unticked by default.

xsrust pushed a commit that referenced this issue Mar 19, 2019
…ed to my DMP" is unticked for new users to the system: (#2066)

- The branding.yml will need to be altered to set the following item to false:
        preferences:
          email:
            users:
              new_comment: false

Fix for issue #2059
@magdalenadrafiova
Copy link

I created a new account but all was still ticked for me -
new-user-03042019

@johnpinto1
Copy link
Contributor

johnpinto1 commented Apr 3, 2019

@xsrust has the property been changed in the branding.yaml on UAT`preferences:

preferences:
      email:
          users:
              new_comment: false

That might explain @magdalenadrafiova issue above.

@dsisu
Copy link

dsisu commented Apr 3, 2019

They are all ticked by default for me too

@xsrust
Copy link
Contributor

xsrust commented Apr 3, 2019

This has been fixed and should run-through as the default for any users who have not explicitly changed their notification settings

@dsisu
Copy link

dsisu commented Apr 3, 2019

Hi, this works for me now. The default appears to be with notifications off. I'm going to close this issue. However, an ideal solution would be to have a notifications digest function, with users having the option to select timings for notifications - every 4 hours, daily, weekly, monthly. New issue available at #2078 (comment)

@dsisu dsisu closed this as completed Apr 3, 2019
@jessn-h
Copy link
Author

jessn-h commented Apr 3, 2019

Thank you all so much for your help with this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants